-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CI-testing on GHA/Windows #337
base: master
Are you sure you want to change the base?
Conversation
1e15689
to
20b6b8f
Compare
Apparently, the deadlock issues on testlayer teardown also happen here.
-- https://github.com/mfussenegger/cr8/pull/337/checks?check_run_id=1395324258#step:6:237 |
Another thing I would like to share in this context is that
will croak with
-- https://github.com/mfussenegger/cr8/pull/337/checks?check_run_id=1395743511#step:6:173 This happens even when running that on bash after 94ad6b2. Apparently, the quotes are taken verbatim when echoing a string through a pipe. I believe [1] is discussing this very issue and others are experiencing similar pains, see also rundeck/rundeck#602 and rundeck/rundeck#1406. |
We have been able to dedicate some more minutes of research into the deadlocking issue on layer teardown when running on Windows. Firstly, we have been able to discover very valuable resources at [1,2,3], which give many general insights into signal handling for child processes on Windows. However, in the context of [1] https://stackoverflow.com/questions/813086/can-i-send-a-ctrl-c-sigint-to-an-application-on-windows |
40bf147
to
5204550
Compare
This test has an anomaly on Windows where the longitude 36.10457754779138 will be returned as 36.104577547791386, i.e. with one more precision digit. While investigating this, I found the diff output for comparing before/after just the other way round than what I would have expected.
UnicodeEncodeError: 'charmap' codec can't encode character '\u2192' in position 65: character maps to <undefined>
README/doctests have problems on Windows, so this is meant as an alternative.
ce7399e
to
9e774b0
Compare
Dear Mathias,
while working on crate/crate-python#388, we faced some deadlock issues when tearing down the testlayer on GHA/Windows. So, we wanted to take the chance to also test the testlayer incorporated into cr8.
Please consider this as a work in progress / draft unless further notice.
With kind regards,
Andreas.