Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dropbox chooser intgn #600

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yashsharma999
Copy link
Contributor

@yashsharma999 yashsharma999 commented Sep 16, 2024

Users can upload files from Dropbox using Dropbox Chooser
Screenshot 2024-09-16 at 10 25 54 PM

Authentication and selecting the file
Screenshot 2024-09-16 at 10 42 00 PM

Screenshot 2024-09-16 at 10 27 30 PM

File is downloaded and upload to the existing Document Upload component.
Screenshot 2024-09-16 at 10 31 28 PM

@yashsharma999 yashsharma999 requested a review from mfts as a code owner September 16, 2024 17:10
Copy link

vercel bot commented Sep 16, 2024

@yashsharma999 is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

what-the-diff bot commented Sep 16, 2024

PR Summary

  • Improvement in File Validation Process
    The procedure for checking whether a file is valid or not has been made more efficient. This was achieved by shifting the logic for this validation into a separate function called fileValidations. This modification makes the process of uploading a document more streamlined.

  • Inclusion of DropboxChooser Component
    A new feature has been introduced, named the DropboxChooser component. It provides functionality for users to import files directly from their Dropbox account, making file uploading a more seamless process.

  • DropboxChooser Integrated with DocumentUploader
    The existing document uploading component, DocumentUpload, has been updated to include the new DropboxChooser component. This enhancement gives users an alternative solution to import files when there are no files selected for uploading.

  • Addition of Dropbox Icon
    A new graphical image (SVG file) for the Dropbox icon has been added. This icon is used within the DropboxChooser button, making it easy for users to recognize the Dropbox file import option.

@mfts
Copy link
Owner

mfts commented Sep 16, 2024

Awesome @yashsharma999

Does it allow multi-file uploads?
We have @tus/server for multi-file uploads and I was wondering if we could integrate that somehow with these integration pickers to let users upload one or multiple files .

@yashsharma999
Copy link
Contributor Author

Yes, it supports multiple file uploads. I'll look into how we can best integrate it with the existing setup.

- this enables multi-file upload
Copy link

github-actions bot commented Sep 30, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@yashsharma999
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@yashsharma999
Copy link
Contributor Author

recheck

@yashsharma999
Copy link
Contributor Author

Made the following change to support multiple file upload

  • Add multiselect: true in Dropbox Chooser options
  • On selecting multiple files from dropbox, trigger a custom drop event on <UploadZone /> component, this component handles all validations and @tus/server related operations.

@mfts let me know your thoughts on this approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants