feat: notification #148
Open
feat: notification #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Aashish-Upadhyay-101 is attempting to deploy a commit to the mftsio Team on Vercel. A member of the Team first needs to authorize it. |
…into feat-webhook
…ay-101/papermark into feat-notification
Closed
mfts
requested changes
Nov 21, 2023
There was a problem hiding this comment.
Looks really good @Aashish-Upadhyay-101 !
I think this feature will enable a lot of great use cases.
I made in-line notes.
Another thing that I noticed, you currently scoped Notification and Webhook by User. I think we need to scope it by Team instead.
I don't think you need to change the API routes, you just need to request the current teamId from the user inside the API functions.
Let me know if you have any questions about it
|
@mfts webhook and notification now have 3 events i.e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mfts ready for review, for "document_viewed" event !