Skip to content

Commit

Permalink
Align window.opener setter reconfiguration behavior
Browse files Browse the repository at this point in the history
In particular, if it fails to reconfigure the property, it should throw a TypeError. Previously it was specified to return a boolean, which was clearly incorrect.
  • Loading branch information
shvaikalesh authored Sep 11, 2023
1 parent c5af9c5 commit 43859d4
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions source
Original file line number Diff line number Diff line change
Expand Up @@ -2972,6 +2972,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute
<li>The <dfn data-x-href="https://tc39.es/ecma262/#sec-createbuiltinfunction">CreateBuiltinFunction</dfn> abstract operation</li>
<li>The <dfn data-x-href="https://tc39.es/ecma262/#sec-createbytedatablock">CreateByteDataBlock</dfn> abstract operation</li>
<li>The <dfn data-x-href="https://tc39.es/ecma262/#sec-createdataproperty">CreateDataProperty</dfn> abstract operation</li>
<li>The <dfn data-x-href="https://tc39.es/ecma262/#sec-definepropertyorthrow">DefinePropertyOrThrow</dfn> abstract operation</li>
<li>The <dfn data-x-href="https://tc39.es/ecma262/#sec-detacharraybuffer">DetachArrayBuffer</dfn> abstract operation</li>
<li>The <dfn data-x-href="https://tc39.es/ecma262/#sec-enumerableownproperties">EnumerableOwnProperties</dfn> abstract operation</li>
<li>The <dfn data-x-href="https://tc39.es/ecma262/#sec-finishdynamicimport">FinishDynamicImport</dfn> abstract operation</li>
Expand Down Expand Up @@ -87723,8 +87724,8 @@ dictionary <dfn dictionary>WindowPostMessageOptions</dfn> : <span>StructuredSeri
context</span> is non-null, then set <span>this</span>'s <span data-x="window bc">browsing
context</span>'s <span>opener browsing context</span> to null.</p></li>

<li><p>If the given value is non-null, then return ?
<span>OrdinaryDefineOwnProperty</span>(<span>this</span>, "<code data-x="">opener</code>", {
<li><p>If the given value is non-null, then perform ?
<span>DefinePropertyOrThrow</span>(<span>this</span>, "<code data-x="">opener</code>", {
[[Value]]: the given value, [[Writable]]: true, [[Enumerable]]: true, [[Configurable]]: true
}).</p></li>
</ol>
Expand Down

0 comments on commit 43859d4

Please sign in to comment.