[Core] Fix broken log configuration (vllm-project#10458)

Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
mfournioux · Nov 28, 2024 · 18b6856 · 18b6856
1 parent a032371
commit 18b6856
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/examples/logging_configuration.md b/examples/logging_configuration.md
@@ -118,7 +118,7 @@ configuration for the root vLLM logger and for the logger you wish to silence:
 {
   "formatters": {
     "vllm": {
-      "class": "vllm.logging.NewLineFormatter",
+      "class": "vllm.logging_utils.NewLineFormatter",
       "datefmt": "%m-%d %H:%M:%S",
       "format": "%(levelname)s %(asctime)s %(filename)s:%(lineno)d] %(message)s"
     }

diff --git a/vllm/logger.py b/vllm/logger.py
@@ -50,7 +50,7 @@
 
 
 def _configure_vllm_root_logger() -> None:
-    logging_config: Optional[Dict] = None
+    logging_config: Dict = {}
 
     if not VLLM_CONFIGURE_LOGGING and VLLM_LOGGING_CONFIG_PATH:
         raise RuntimeError(
@@ -75,6 +75,11 @@ def _configure_vllm_root_logger() -> None:
                              type(custom_config).__name__)
         logging_config = custom_config
 
+    for formatter in logging_config.get("formatters", {}).values():
+        # This provides backwards compatibility after #10134.
+        if formatter.get("class") == "vllm.logging.NewLineFormatter":
+            formatter["class"] = "vllm.logging_utils.NewLineFormatter"
+
     if logging_config:
         dictConfig(logging_config)