Conversation
|
I'm not sure why my level four subheadings subheadings are not showing up in the table of contents. |
|
is this |
|
Hopefully by tomorrow 🤞 |
src/annotated/ex3.md
Outdated
| cout << "Number of finite element unknowns: " | ||
| << fespace->GetTrueVSize() << endl; | ||
| ``` | ||
| Here, the `FiniteElementCollection` corresponds to Nédélec basis functions because Nédélec finite elements have optimal approximation approximation properties in $H(\mathrm{curl})$; i.e., the energy space over which problem (2) is well-defined. |
There was a problem hiding this comment.
It might be worth mentioning briefly that Nedelec basis functions are vector-valued in contrast to the scalar-valued basis functions used in example 2. Here we have a one-to-one correspondence between DoFs and basis functions whereas in example 2 there are multiple DoFs associated with each basis function to represent different vector components. I'm not sure how best to describe this contrast but I think it is not obvious and should be mentioned.
There was a problem hiding this comment.
I added the following remark:
The Nédélec basis functions are intrinsically vector-valued. In particular, they cannot be constructed as a Cartesian product of a scalar basis, unlike the vector-valued basis used in [Example 2](http://127.0.0.1:8000/annotated/ex2) for linear elasticity. In turn, these basis functions are typically nonzero in all components, and their degree-of-freedom numbering does not represent their active vector components.
src/annotated/ex6.md
Outdated
|
|
||
| Below is the classification of each mesh file used in the sample runs, indicating the dimension, element type, and whether it is conforming or non-conforming: | ||
|
|
||
| | Mesh File | Dimension | Element Type | Classification | |
There was a problem hiding this comment.
It was not clear to me what was meant by the "Classification" heading. I assumed you were referring to whether the mesh file was conforming or not because this table purports to describe the mesh files not the computational meshes. Perhaps another column heading could be used to declare the types of AMR that are available through this example (remember the "-nc" flag can override the default for simplex meshes) for each particular mesh.
There was a problem hiding this comment.
I opted to remove the final column that the student added
|
Thanks for your comments, @mlstowell and @acfisher! Please let me know if I missed anything! |
|
@mlstowell please let me know if I've addressed your comments, or if you have any new ones :) |
This PR provides annotated versions of examples 1, 2, 3, 6, and 36
This work originated within the Center for Information Geometric Mechanics and Optimization (CIGMO), a PSAAP-IV Focused Investigatory Center supported by the U.S. Department of Energy, National Nuclear Security Administration under Award Number DE-NA0004261.