Remove pimple as a supported container #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Steel <[email protected]>
|
I'll have to come back to this later to resolve the psalm issues… |
|
Related to mezzio/mezzio#145 |
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Xerkus
reviewed
Jan 8, 2024
Comment on lines
58
to
71
| $this->container | ||
| ->expects($this->exactly(2)) | ||
| ->method('get') | ||
| ->withConsecutive( | ||
| [RouterInterface::class], | ||
| [TemplateRendererInterface::class], | ||
| ) | ||
| ->with(self::callback(static function (string $name): bool { | ||
| self::assertTrue(in_array($name, [ | ||
| RouterInterface::class, | ||
| TemplateRendererInterface::class, | ||
| ])); | ||
|
|
||
| return true; | ||
| })) | ||
| ->willReturnOnConsecutiveCalls( | ||
| $this->router, | ||
| $renderer |
There was a problem hiding this comment.
Imo, replace mock with a stub and use return map.
There was a problem hiding this comment.
Or add return map since assumption about call older is brittle
gsteel
force-pushed
the
remove-pimple-support
branch
2 times, most recently
from
eabb590
to
f857563
Compare
Signed-off-by: George Steel <[email protected]>
gsteel
force-pushed
the
remove-pimple-support
branch
from
f857563
to
d73ad7b
Compare
Xerkus
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove support for Pimple due to the abandonment of
laminas-pimple-config