Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency psr/http-message to v2 #39

Merged
merged 2 commits into from
May 30, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 4, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
psr/http-message require major ^1.0 -> ^1.0 || ^2.0

Release Notes

php-fig/http-message

v2.0

Compare Source

Added return types, see https://www.php-fig.org/psr/psr-7/meta/[#​72](https://togithub.com/php-fig/http-message/issues/72)-type-additions


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

Read more information about the use of Renovate Bot within Laminas.

@renovate renovate bot added the renovate label Apr 4, 2023
@boesing
Copy link
Member

boesing commented Apr 4, 2023

Please do not just merge this, there is no check which verifies that psr/http-message v2 is installed.
I wonder if we can somehow improve this by slightly modifying the composer.json to get rid of non-platform dependency widening packages.

So in this case, for locked nothing might change, for lowest we remove all upper major versions and for latest we remove all lower major versions.

This will become:

lowest

{
    "require": {
        "psr/http-message": "^1.0"
    }
}

latest

{
    "require": {
        "psr/http-message": "^2.0"
    }
}

We had the same issue in laminas/laminas-cache where PSR-6 & PSR-16 updates did not had failed tests after extending the supported dependency range. That was, because there is nothing which verifies if these versions are actually being installed.

So most probably, for every dependency which declares multiple major versions, a matrix job needs to be created which enforces all major versions so that we can actually verify that we do install them.

Any ideas/thoughts on this @mezzio/technical-steering-committee?

I think that Matthew also meant this kind of check here.

@weierophinney
Copy link
Contributor

@boesing Also... I'll have PRs incoming this week for Diactoros around this. I think once those are in place, we can tackle some of these. In most cases for consumers, however, we should be able to allow ^1.0 || ^2.0. As you note, however, we need to be able to test against both in the CI.

@Ocramius Ocramius requested a review from gsteel April 6, 2023 15:55
@renovate renovate bot force-pushed the renovate/psr-http-message-2.x branch from c53ed32 to 5a1bda1 Compare April 6, 2023 15:55
@Ocramius Ocramius added the Enhancement New feature or request label Apr 6, 2023
@renovate renovate bot force-pushed the renovate/psr-http-message-2.x branch 4 times, most recently from c7f36bd to 61d93b0 Compare April 13, 2023 01:19
@renovate renovate bot force-pushed the renovate/psr-http-message-2.x branch 2 times, most recently from 4a946c2 to 62936fb Compare April 24, 2023 01:33
@renovate renovate bot force-pushed the renovate/psr-http-message-2.x branch 4 times, most recently from 0697de5 to 48e2199 Compare May 7, 2023 00:13
| datasource | package          | from | to  |
| ---------- | ---------------- | ---- | --- |
| packagist  | psr/http-message | 1.1  | 2.0 |


Signed-off-by: Renovate Bot <[email protected]>
@renovate renovate bot force-pushed the renovate/psr-http-message-2.x branch from 48e2199 to 20ac074 Compare May 7, 2023 00:15
@renovate
Copy link
Contributor Author

renovate bot commented May 7, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@Xerkus Xerkus added this to the 1.12.0 milestone May 7, 2023
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is currently testing on both major versions for lowest/latest.

Given that we don't currently have a workflow for testing strategies per major release of deps, do you have any objection to merging and releasing @boesing

Copy link
Member

@internalsystemerror internalsystemerror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsteel gsteel assigned gsteel and unassigned boesing May 30, 2023
@gsteel gsteel merged commit ae583a3 into 1.12.x May 30, 2023
@gsteel gsteel deleted the renovate/psr-http-message-2.x branch May 30, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request renovate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants