-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Adding a complete Docker setup #7
Open
TBG-FR
wants to merge
10
commits into
meysamhadeli:main
Choose a base branch
from
TBG-FR:docker-setup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sql databases should be created
…ensions (VSCode for example)
An implementation of Kubernetes for the services would be a great improvement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to try to run the whole project, and doing it using Docker, so here's my contribution on that topic 😉
DONE / Setup ✅
passenger
,booking
,flight
,identity
)compose.yaml
files.env
file, replacinglocalhost
by containers hostnamesTODO / Improvements 🚧
localhost
references inbooking-microservices-nestjs/src/booking/src/booking/http-client/services/passenger/passenger-client.ts
Line 17 in fb352ad
booking-microservices-nestjs/src/booking/src/booking/http-client/services/flight/flight.client.ts
Line 22 in fb352ad
compose.infrastructure.yaml
)compose.services.yaml
to be able to do live modifications ? (can then face issues withnode_modules
synchronization between host (files on disk, mounted by the volume mapping) and container (newly generated files, built via docker))