Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket support #23

Merged
merged 8 commits into from
Apr 7, 2020
Merged

Websocket support #23

merged 8 commits into from
Apr 7, 2020

Conversation

nikolap
Copy link
Contributor

@nikolap nikolap commented Apr 3, 2020

Goals with this feature addition. If any are misaligned with the lib, please push back.

  1. Allow user to override any of the implementations, e.g. custom listener or callback
  2. Attempt to keep API similar (though not identical) to immutant -- should allow for relatively easy plugability with libs like sente
  3. Make modular, i.e. so that it can be moved as needed and not directly tied into pohjavirta. The rationale is that many web applications do not require this so it should be an opt-in functionality with custom user-written code to hook it together (perhaps should add helpers?)

Open to feedback and discussion before merging.

Re #1

@ikitommi
Copy link
Member

ikitommi commented Apr 7, 2020

Looking good, thanks!!

@ikitommi ikitommi merged commit f543d14 into metosin:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants