(WIP) Read body in IO pool #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalekale
force-pushed
the
feature/body-in-io-pool
branch
from
d3a7336 to
d00820e
Compare
ikitommi
reviewed
Nov 24, 2019
| (handler) | ||
| (response/send-response exchange)))] | ||
| (if (fn? (:body request)) | ||
| ((:body request) handler request) |
There was a problem hiding this comment.
Looks good, but is not optimal in perf I believe: :body is looked up twice, and as it's backed by the slow Potemkin lazy-map, we lose 2*70ns here. I would suggest:
- adding the
:bodytopohjavirta.request.Requestfor fast access (few nanos) - maybe add a Protocol like
pohjavirta.request.HandleWithBodythat has(handle-with-body [_ handler])function that is invoked inpohjavirta.serverand would do things behind the scenes. To remove theifcompletely, there could beAsyncPartialRequestandSyncPartialRequestthat have their own implementation ofHandleWithBody, as we know how to parse the body already when server is created (with:dispatchor not).
bsless
reviewed
May 26, 2021
| (fn [handler request] | ||
| (-> exchange | ||
| .getRequestReceiver | ||
| (.receiveFullBytes (proxy [Receiver$FullBytesCallback] [] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit silly, but it works.