Require generator for :gen/fmap
#1120
Open
+30
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:gen/fmapis fednilif its schema cannot create a generator. This does not seem like desirable semantics because silent failures could happen if the:gen/fmapfunction is permissive, likefirstor a keyword, making the entire generator returnnils.Could we reconsider this? Perhaps
:gen/fmappredated:gen/returnand:gen/elements, but we can certainly now force the user to be explicit here. Importantly, is this worth the risk breaking things by fixing it?Also includes a fix for the CLJS version of
alphanumeric-char?in the tests.