Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #413 #414

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for #413 #414

wants to merge 2 commits into from

Conversation

ToastHawaii
Copy link

I found out if i remove the cached subscription things works well, not sure if it is a good idea. #413

@ToastHawaii
Update useSubscribe.ts
494f682 
Fix to make things more stable.
@CLAassistant
Copy link

CLAassistant commented Nov 13, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Grubba27 Grubba27 requested a review from radekmie November 13, 2024 14:02
radekmie
radekmie reviewed Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@radekmie radekmie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, but I'm not sure about two things:

  1. Why is it limited to !error?
  2. Can we reproduce it somehow? It'd be great to cover such an edge case with a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grubba27 Grubba27 Grubba27 left review comments

@radekmie radekmie radekmie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ToastHawaii @CLAassistant @radekmie @Grubba27