Package.json exports #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests seem to be failing with node 4 and 5. I don't think it is related to this PR. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements package.json exports, following Node's specification. If I did it correctly, it should be feature complete and spec compliant. The main thing missing is many of the errors and assertions mentioned in the spec - due to how Meteor creates the bundles, I'm not sure how many of are relevant.
There's also a related feature of package.json imports. This PR does not implement it, but there probably isn't much more work needed to also support it.
This PR also reverts e5d9028. This comment was never published, and superseded by the current top level await implementation.