Corrected the Column calculation from Tile GID in the TileLayer class #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entation fault tho)
…pdate() in TileLayer.cpp
… rendered correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**The argument passed to the TextureManager::DrawTile() function call was incorrect it produced wrong index value(column value) for the variable currentframe.(this change needs to be pulled other 2 are not that that necessary they are more like expansion possibilities)
Also since the ObjectLayer and ObjectGroup classes corresponding to the TMX format's Object and ObjectGroup Layer are not yet implemented ,which can be easily implemented by inheriting the abstract class Layer. I commented out the Object::update() calls and the collision detection calls in the Game class.
I added a test dir