-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI, add support for metamath-de.pdf #248
base: master
Are you sure you want to change the base?
Conversation
german/metamath.tex
Outdated
@@ -2554,7 +2555,7 @@ \section{Ihr erster Beweis}\label{frstprf} | |||
|
|||
Ein oft nützlicher Befehl ist \texttt{minimize{\char`\_}with*/brief}, der versucht, den Beweis zu verkürzen. Er kann den Prozess des Beweisens effizienter machen, indem er Sie einen etwas "`schlampigen"' Beweis schreiben lässt und ihn dann durch einige feine Optimierungsdetails für Sie bereinigt (obwohl er keine Wunder vollbringen kann, wie z.B. die Umstrukturierung des gesamten Beweises). | |||
|
|||
\section{\sloppy Hinweise zur Bearbeitung einer Daten\-basis} | |||
\section{Hinweise zur Bearbeitung einer Daten\-basis} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the \sloppy command, LaTex does not wrap "Datenbasis", but creates a single line which is a little bit longer than the block size. I would suggest to insert \texorpdfstring{\\}{}
before "Datenbasis" (wraps the line before "Datenbasis",).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a closer look at the tex-files only, they are OK except the removal of the \sloppy command. But this can be aligned later.
I cannot check if the scripts are working correctly.
@@ -2554,7 +2555,7 @@ \section{Ihr erster Beweis}\label{frstprf} | |||
|
|||
Ein oft nützlicher Befehl ist \texttt{minimize{\char`\_}with*/brief}, der versucht, den Beweis zu verkürzen. Er kann den Prozess des Beweisens effizienter machen, indem er Sie einen etwas "`schlampigen"' Beweis schreiben lässt und ihn dann durch einige feine Optimierungsdetails für Sie bereinigt (obwohl er keine Wunder vollbringen kann, wie z.B. die Umstrukturierung des gesamten Beweises). | |||
|
|||
\section{\sloppy Hinweise zur Bearbeitung einer Daten\-basis} | |||
\section{\texorpdfstring{\raggedright}{}Hinweise zur Bearbeitung einer Datenbasis} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really working? I get the following error:
Argument of \@sect has an extra }. ...nweise zur Bearbeitung einer Datenbasis}
Can \raggedright be used in a \section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be working for me locally, and the CI run does not show the error message. Do you still get that message when compiling it using ./generate-pdf normal de
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using the tools TeXstudio and MiKTeX to work with (La)TeX files, including the generation of PDF documents. And these tools give me the error. But if it is working with your script/environment, it's fine for me. I would have a closer look on this issue later. So this PR is still accepted by me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following combination of \sloppy and \texorpdfstring is working:
\section{\texorpdfstring{\sloppy}{}Hinweise zur Bearbeitung einer Daten\-basis}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that and it produces exactly the same result as nothing at all: the section looks something like:
2.5 Hinweise zur Bearbeitung einer Daten-
basis
where the Daten-
sticks out very slightly. IMO the sticking out isn't bad enough that it seems worth addressing in the first place, which is why my first revision just removed the \sloppy
entirely.
This moves the metamath-german.pdf file out of the repo and into a CI artifact, as well as a release when pushing to master.