Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI, add support for metamath-de.pdf #248

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add CI, add support for metamath-de.pdf #248

wants to merge 8 commits into from

Conversation

digama0
Copy link
Member

@digama0 digama0 commented Dec 16, 2023

This moves the metamath-german.pdf file out of the repo and into a CI artifact, as well as a release when pushing to master.

@@ -2554,7 +2555,7 @@ \section{Ihr erster Beweis}\label{frstprf}

Ein oft nützlicher Befehl ist \texttt{minimize{\char`\_}with*/brief}, der versucht, den Beweis zu verkürzen. Er kann den Prozess des Beweisens effizienter machen, indem er Sie einen etwas "`schlampigen"' Beweis schreiben lässt und ihn dann durch einige feine Optimierungsdetails für Sie bereinigt (obwohl er keine Wunder vollbringen kann, wie z.B. die Umstrukturierung des gesamten Beweises).

\section{\sloppy Hinweise zur Bearbeitung einer Daten\-basis}
\section{Hinweise zur Bearbeitung einer Daten\-basis}
Copy link
Contributor

@avekens avekens Dec 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the \sloppy command, LaTex does not wrap "Datenbasis", but creates a single line which is a little bit longer than the block size. I would suggest to insert \texorpdfstring{\\}{} before "Datenbasis" (wraps the line before "Datenbasis",).

Copy link
Contributor

@avekens avekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a closer look at the tex-files only, they are OK except the removal of the \sloppy command. But this can be aligned later.

I cannot check if the scripts are working correctly.

@@ -2554,7 +2555,7 @@ \section{Ihr erster Beweis}\label{frstprf}

Ein oft nützlicher Befehl ist \texttt{minimize{\char`\_}with*/brief}, der versucht, den Beweis zu verkürzen. Er kann den Prozess des Beweisens effizienter machen, indem er Sie einen etwas "`schlampigen"' Beweis schreiben lässt und ihn dann durch einige feine Optimierungsdetails für Sie bereinigt (obwohl er keine Wunder vollbringen kann, wie z.B. die Umstrukturierung des gesamten Beweises).

\section{\sloppy Hinweise zur Bearbeitung einer Daten\-basis}
\section{\texorpdfstring{\raggedright}{}Hinweise zur Bearbeitung einer Datenbasis}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really working? I get the following error:
Argument of \@sect has an extra }. ...nweise zur Bearbeitung einer Datenbasis}

Can \raggedright be used in a \section?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be working for me locally, and the CI run does not show the error message. Do you still get that message when compiling it using ./generate-pdf normal de?

Copy link
Contributor

@avekens avekens Dec 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using the tools TeXstudio and MiKTeX to work with (La)TeX files, including the generation of PDF documents. And these tools give me the error. But if it is working with your script/environment, it's fine for me. I would have a closer look on this issue later. So this PR is still accepted by me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following combination of \sloppy and \texorpdfstring is working:
\section{\texorpdfstring{\sloppy}{}Hinweise zur Bearbeitung einer Daten\-basis}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that and it produces exactly the same result as nothing at all: the section looks something like:

2.5    Hinweise zur Bearbeitung einer Daten-
       basis

where the Daten- sticks out very slightly. IMO the sticking out isn't bad enough that it seems worth addressing in the first place, which is why my first revision just removed the \sloppy entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants