-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add pull bmo e2e optional to prow #970
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Huy Mai <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits
@lentzi90 PTAL
@@ -0,0 +1,89 @@ | |||
import java.text.SimpleDateFormat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be the name of the file should have optional in it as well?
} | ||
agent none | ||
stages { | ||
stage("Run Baremetal Operator e2e tests") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stage("Run Baremetal Operator e2e tests") { | |
stage("Run Baremetal Operator optional e2e tests") { |
} | ||
} | ||
} | ||
stage("Run Baremetal Operator e2e tests") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stage("Run Baremetal Operator e2e tests") { | |
stage("Run Baremetal Operator optional e2e tests") { |
/hold |
Optional BMO e2e tests have been running as periodic jobs by Github agents, adding only the pull jobs so that they can be triggered on PRs as well.