-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enables optionally multiplatform container builds #960
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @e-minguez. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3c038b4
to
219d75e
Compare
required: false | ||
description: "Architecture platforms for the image build (linux/amd64,linux/arm64, etc.)" | ||
type: string | ||
default: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am thinking if we would need a default value here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess (honestly, I didn't tested it) that if you don't explicitly set multiPlatform: true
this will be ignored and built against the arch where it has been executed (linux/amd64
by default IIRC)
@e-minguez thanks a lot for the PR, please check the DCO failure and fix it |
/ok-to-test |
219d75e
to
46101a9
Compare
Signed-off-by: e-minguez <[email protected]>
46101a9
to
e0cdab7
Compare
@e-minguez: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
metal3-io/ironic-image#615