Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cncf sandbox proposal dead link #498

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix cncf sandbox proposal dead link #498

merged 1 commit into from
Jan 20, 2025

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Jan 20, 2025 •
edited
Loading

Fix CNCF sandbox proposal dead link in foundation-proposal.md.

Fixes #443

@tuminoid
fix cncf sandbox proposal dead link
0eb29c1 
Fix CNCF sandbox proposal dead link.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 20, 2025
@tuminoid
Copy link
Member Author

Supersedes stale #477 to get this resolved.

@tuminoid tuminoid mentioned this pull request Jan 20, 2025
Closed
@tuminoid
Copy link
Member Author

/cc @kashifest @Rozzii @lentzi90

Rozzii
Rozzii reviewed Jan 20, 2025
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2025
lentzi90
lentzi90 reviewed Jan 20, 2025
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tuminoid
Copy link
Member Author

tuminoid commented Jan 20, 2025 •
edited
Loading

/lgtm

@Rozzii Can you switch to approve, since you're approver in design?

@tuminoid tuminoid requested a review from Rozzii January 20, 2025 08:04
@Rozzii
Copy link
Member

Rozzii commented Jan 20, 2025

/lgtm cancel

@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2025
@Rozzii
Copy link
Member

Rozzii commented Jan 20, 2025

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2025
@metal3-io-bot metal3-io-bot merged commit d6a0363 into metal3-io:main Jan 20, 2025
8 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/fix-cncf-link branch January 20, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@dtantsur dtantsur Awaiting requested review from dtantsur

@kashifest kashifest Awaiting requested review from kashifest

@Rozzii Rozzii Awaiting requested review from Rozzii

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix dead links at foundation-proposal.md
5 participants
@tuminoid @Rozzii @metal3-io-bot @elfosardo @lentzi90