Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for Firmware Updates to Metal3 Book #464

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Add documentation for Firmware Updates to Metal3 Book #464

merged 1 commit into from
Oct 1, 2024

Conversation

iurygregory
Copy link
Member

No description provided.

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 9, 2024
@tuminoid
Copy link
Member

tuminoid commented Aug 9, 2024

/cc @elfosardo @dtantsur

elfosardo
elfosardo suggested changes Aug 9, 2024
View reviewed changes
Copy link
Member

@elfosardo elfosardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! some comments inline

docs/user-guide/src/bmo/firmware_components.md Outdated Show resolved Hide resolved
docs/user-guide/src/bmo/firmware_components.md Outdated Show resolved Hide resolved
docs/user-guide/src/bmo/firmware_components.md Outdated Show resolved Hide resolved
docs/user-guide/src/bmo/firmware_components.md Outdated Show resolved Hide resolved
docs/user-guide/src/bmo/firmware_components.md Outdated Show resolved Hide resolved
docs/user-guide/src/bmo/firmware_components.md Outdated Show resolved Hide resolved
docs/user-guide/src/bmo/firmware_components.md Outdated Show resolved Hide resolved
docs/user-guide/src/bmo/firmware_components.md Outdated Show resolved Hide resolved
docs/user-guide/src/bmo/firmware_components.md Outdated Show resolved Hide resolved
@iurygregory
Copy link
Member Author

@elfosardo @dtantsur can you take another look ? Thanks!

tuminoid
tuminoid reviewed Aug 22, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding more documentation!

It'd be great if you could wrap the long lines at 80, even if we don't enforce it yet in the markdownlint. This way it doesn't add more wrapping issues when the documents are eventually fixed.

@iurygregory
Copy link
Member Author

Thanks @tuminoid , I've updated to wrap the lines.

@tuminoid
Copy link
Member

Thanks @tuminoid , I've updated to wrap the lines.

Lovely, thanks a lot!

tuminoid
tuminoid reviewed Aug 22, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2024
dtantsur
dtantsur requested changes Aug 28, 2024
View reviewed changes
docs/user-guide/src/SUMMARY.md Outdated Show resolved Hide resolved
docs/user-guide/src/bmo/firmware_components.md Outdated Show resolved Hide resolved
docs/user-guide/src/bmo/firmware_components.md Outdated Show resolved Hide resolved
docs/user-guide/src/bmo/firmware_components.md Outdated Show resolved Hide resolved
docs/user-guide/src/bmo/firmware_components.md Outdated Show resolved Hide resolved
docs/user-guide/src/bmo/firmware_components.md Outdated Show resolved Hide resolved
docs/user-guide/src/bmo/firmware_components.md Outdated Show resolved Hide resolved
docs/user-guide/src/bmo/firmware_components.md Outdated Show resolved Hide resolved
docs/user-guide/src/bmo/firmware_components.md Outdated Show resolved Hide resolved
docs/user-guide/src/bmo/firmware_components.md Outdated Show resolved Hide resolved
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2024
@iurygregory iurygregory changed the title Add documentation for HostFirmwareComponents to Metal3 Book Add documentation for Firmware Updates to Metal3 Book Aug 28, 2024
@iurygregory
Copy link
Member Author

@dtantsur can you take another look? Thanks!

kashifest
kashifest reviewed Sep 25, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small nits.
+1 on the change requested by @dtantsur

docs/user-guide/src/bmo/firmware_updates.md Outdated Show resolved Hide resolved
docs/user-guide/src/bmo/firmware_updates.md Outdated Show resolved Hide resolved
docs/user-guide/src/bmo/firmware_updates.md Outdated Show resolved Hide resolved
@iurygregory iurygregory force-pushed the add-hostfirmwarecomponents branch 2 times, most recently from e10378d to f4e91c2 Compare September 27, 2024 11:36
@kashifest
Copy link
Member

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2024
@iurygregory
Add documentation for Firmware Updates
b4617e4 
Signed-off-by: Iury Gregory Melo Ferreira <[email protected]>
dtantsur
dtantsur approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@dtantsur dtantsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit 0c09d74 into metal3-io:main Oct 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@elfosardo elfosardo elfosardo requested changes

@tuminoid tuminoid tuminoid left review comments

@dtantsur dtantsur dtantsur approved these changes

@zhouhao3 zhouhao3 Awaiting requested review from zhouhao3

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@iurygregory @tuminoid @kashifest @metal3-io-bot @dtantsur @elfosardo