Determine whether initcontainer is needed through IPAConfig options

[matthewei]

Some times we can build a http server out of cluster and we can also ues it to be as a image-server. And we can upload kernal and ramdisk into it. So I think we may don't need the init-Pod in Ironic's Pod.

I have modified the Ironic CRD

apiVersion: metal3.io/v1alpha1
kind: Ironic
metadata:
  name: ironic-server
spec:
  images:
    ipaConfig:
      ipaEnabled: true
      ironic: registry.paas/metal3-io/ironic:v1.0
      ramdiskDownloader: registry.paas/metal3-io/ipa-config:v17

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dtantsur for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[metal3-io-bot]

Hi @matthewei. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[matthewei]

@dhellmann Hi , Could you have a look my code.

[dtantsur]

I'd rather keep the Images structure intact, especially since what you're adding is not an "IPA config", nor are you "enabling IPA". IPA is pretty much required for Ironic, you're enabling/disabling its downloader.

Let's just add disableRamdiskDownloader as a top-level option? (disable instead of enable so that it can default to false).

[matthewei]

OK, I will modify my code.

[matthewei]

@dtantsur Is it ok?

[dtantsur]

This should not be part of Images, especially since the Images structure in its current form will be gone.

[matthewei]

OK, I would like to refactor my code.

[metal3-io-bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.