Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Install python-ironicclient in /usr/local #610

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

derekhiggins
Copy link
Member

This is where python3.9 has been installed
Fixes: #609

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 16, 2025
@dtantsur
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2025
@dtantsur
Copy link
Member

Sorry, got two places confused in the now deleted comment. My approval holds.

/override metal3-centos-e2e-integration-test-main
/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@dtantsur: Overrode contexts on behalf of dtantsur: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

Sorry, got two places confused in the now deleted comment. My approval holds.

/override metal3-centos-e2e-integration-test-main
/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This is where python3.9 has been installed
Fixes: metal3-io#609

Signed-off-by: Derek Higgins <[email protected]>
@derekhiggins
Copy link
Member Author

Updated to also change the entrypoint to /usr/local/bin/baremetal as this has now changed

@elfosardo
Copy link
Member

/override metal3-centos-e2e-integration-test-main
/override metal3-ubuntu-e2e-integration-test-main

@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot
Copy link
Contributor

@elfosardo: Overrode contexts on behalf of elfosardo: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main
/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2025
@metal3-io-bot metal3-io-bot merged commit 6ae9e16 into metal3-io:main Jan 16, 2025
5 checks passed
@metal3-io-bot metal3-io-bot added this to the ironic-image - v28.0 milestone Jan 16, 2025
iurygregory pushed a commit to iurygregory/ironic-image that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'ironicclient'
4 participants