Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 add more prior art to releasing.md #601

Merged

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Dec 9, 2024

Add prior art PRs to fixing build badges, as well as prior art link to 27.0.0 release, where we first time added extra information about upstream Ironic changelog and full commit range link.

Add prior art PRs to fixing build badges, as well as prior art link
to 27.0.0 release, where we first time added extra information about
upstream Ironic changelog and full commit range link.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 9, 2024
@tuminoid
Copy link
Member Author

tuminoid commented Dec 9, 2024

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

/cc @elfosardo @kashifest

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

/cc @elfosardo @kashifest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid tuminoid changed the title 📖 add prior art to releasing.md 📖 add more prior art to releasing.md Dec 9, 2024
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2024
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tuminoid
Copy link
Member Author

/cc @elfosardo @dtantsur

@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024
@metal3-io-bot metal3-io-bot merged commit 8c48d47 into metal3-io:main Dec 16, 2024
7 checks passed
@metal3-io-bot metal3-io-bot added this to the ironic-image - v27.0 milestone Dec 16, 2024
@metal3-io-bot metal3-io-bot deleted the tuomo/add-release-note-about-more-info branch December 16, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants