🌱 Add build container image as a job in release wf #839
Conversation
This adds build-container-image as a job in the release wf. After the release note draft is created, the container image will be created. Signed-off-by: Huy Mai <[email protected]>
metal3-io-bot
added
the
size/S
mquhuy
changed the title
|
/lgtm |
| with: | ||
| image-name: "ip-address-manager" | ||
| pushImage: true | ||
| ref: ${{ needs.push_release_tags.outputs.release_tag }} |
There was a problem hiding this comment.
| ref: ${{ needs.push_release_tags.outputs.release_tag }} | |
| ref: ${{ env.RELEASE_TAG }} |
We can also use env.RELEASE_TAG here right?
There was a problem hiding this comment.
Not really. The release job isn't configured to run before build_ipam. They could be running in parallel, or in any order. Only the push_release_tag is guaranteed to run first. Also, I'm not sure if the env is maintained between the jobs.
Is there any reason for using env instead of outputs?
There was a problem hiding this comment.
no reason it just looked simpler.
|
/approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adilGhaffarDev, kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/override metal3-ubuntu-e2e-integration-test-release-1-9 |
|
@adilGhaffarDev: adilGhaffarDev unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override metal3-ubuntu-e2e-integration-test-release-1-9 |
|
@kashifest: Overrode contexts on behalf of kashifest: metal3-ubuntu-e2e-integration-test-release-1-9 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/close This PR merges to the wrong branch. Redo in #840 |
|
/close |
|
@mquhuy wont we need this for release-1.9 patch releases anyhow or do we do the releases from main branch always? |
This adds build-container-image as a job in the release wf. After the release note draft is created, the container image will be created.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #772