Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 fix dependabot workflow permissions #415

Merged
merged 1 commit into from
Jan 15, 2024
Merged

🌱 fix dependabot workflow permissions #415

merged 1 commit into from
Jan 15, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Jan 15, 2024 •
edited
Loading

Dependabot itself wouldn't need more than pull-requests: write, but we have added on generated code part which does need to write contents on top of the PR, so restoring the permissions.

Symptoms are seen in #414

@tuminoid
fix dependabot workflow permissions
55e103d 
Dependabot itself wouldn't need more than pull-requests: write, but
we have added on generated code part which does need to write contents
on top of the PR, so restoring the permissions.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 15, 2024
@tuminoid
Copy link
Member Author

/override test-centos-e2e-integration-main test-ubuntu-integration-main
Irrelevant.

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-e2e-integration-main, test-ubuntu-integration-main

In response to this:

/override test-centos-e2e-integration-main test-ubuntu-integration-main
Irrelevant.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid tuminoid mentioned this pull request Jan 15, 2024
Merged
@maxrantil
Copy link

LGTM

kashifest
kashifest reviewed Jan 15, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2024
smoshiur1237
smoshiur1237 reviewed Jan 15, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2024
@metal3-io-bot metal3-io-bot merged commit 2c6d759 into metal3-io:main Jan 15, 2024
18 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/fix-dependabot-permissions branch January 15, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@kashifest kashifest kashifest left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tuminoid @metal3-io-bot @maxrantil @kashifest @smoshiur1237