Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix error in build image github action #388

Merged
merged 1 commit into from
Nov 24, 2023
Merged

🐛 Fix error in build image github action #388

merged 1 commit into from
Nov 24, 2023

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Nov 24, 2023

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 24, 2023
@mquhuy mquhuy force-pushed the mquhuy/fix-build-trigger-error branch from 20c2e57 to 50cbf30 Compare November 24, 2023 13:27
@mquhuy
Copy link
Member Author

mquhuy commented Nov 24, 2023

/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@mquhuy mquhuy force-pushed the mquhuy/fix-build-trigger-error branch from 50cbf30 to 5790535 Compare November 24, 2023 13:38
@mquhuy mquhuy force-pushed the mquhuy/fix-build-trigger-error branch from 5790535 to 61cce9e Compare November 24, 2023 13:44
kashifest
kashifest reviewed Nov 24, 2023
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2023
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2023
@kashifest
Copy link
Member

/test-centos-e2e-integration-main /test-ubuntu-integration-main
No point running integration tests, wont check anything for github actions

/override test-centos-e2e-integration-main
/override test-ubuntu-integration-main

@metal3-io-bot
Copy link
Contributor

@kashifest: Overrode contexts on behalf of kashifest: test-centos-e2e-integration-main, test-ubuntu-integration-main

In response to this:

/test-centos-e2e-integration-main /test-ubuntu-integration-main
No point running integration tests, wont check anything for github actions

/override test-centos-e2e-integration-main
/override test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot merged commit 101491a into metal3-io:main Nov 24, 2023
6 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/fix-build-trigger-error branch November 24, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mquhuy @metal3-io-bot @kashifest