Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mirantis to Adopters File #26

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

randybias
Copy link

Add Mirantis to the Metal3 adopters file with our two use cases for Metal3.

Add Mirantis to the Metal3 adopters file with our two use cases for Metal3.
@metal3-io-bot
Copy link
Contributor

Hi @randybias. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2025
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/approve

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 11, 2025
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2025
@Rozzii
Copy link
Member

Rozzii commented Feb 11, 2025

Huge thanks for updating the list and disclosing Mirantis as an adopter!
Could you please sign the commit to pass the DCO check?

@kashifest
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2025
@dtantsur
Copy link
Member

Welcome folks!

@adilGhaffarDev
Copy link
Member

Thank you @randybias and welcome.
Can you sign the commit and push again so we can merge this PR?

git commit --amend -s -S
Should do the trick.

@tuminoid
Copy link
Member

@randybias could you address the DCO issue so we can get your PR merged? Thanks!

@tuminoid
Copy link
Member

/retitle Add Mirantis to Adopters File
Typofix.

@randybias PTAL and fix the DCO. We'd love to get this merged.

@metal3-io-bot metal3-io-bot changed the title Add Mirantis to Adopers File Add Mirantis to Adopters File Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants