🌱 Fix capi-md-e2e test to support taint propagation feature#2981
🌱 Fix capi-md-e2e test to support taint propagation feature#2981metal3-io-bot merged 1 commit intometal3-io:mainfrom
Conversation
|
/test ? |
metal3-io-bot
added
the
size/M
|
@adilGhaffarDev: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
adilGhaffarDev
force-pushed
the
fix-capi-md-test/adil
branch
2 times, most recently
from
071168d to
0bc9a8c
Compare
|
/test metal3-centos-e2e-capi-md-test-main |
adilGhaffarDev
force-pushed
the
fix-capi-md-test/adil
branch
from
0bc9a8c to
faf85c0
Compare
|
/test metal3-centos-e2e-capi-md-test-main |
|
/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
|
we need to use 1.12-rc of capi to enable this, I will update the pr to use it. |
adilGhaffarDev
force-pushed
the
fix-capi-md-test/adil
branch
from
faf85c0 to
9f72537
Compare
|
/test metal3-centos-e2e-capi-md-test-main |
adilGhaffarDev
force-pushed
the
fix-capi-md-test/adil
branch
from
9f72537 to
88b5e7a
Compare
|
/test metal3-centos-e2e-capi-md-test-main |
adilGhaffarDev
force-pushed
the
fix-capi-md-test/adil
branch
from
88b5e7a to
915dc51
Compare
|
/test metal3-centos-e2e-capi-md-test-main |
adilGhaffarDev
force-pushed
the
fix-capi-md-test/adil
branch
from
915dc51 to
9dabd80
Compare
|
/test metal3-centos-e2e-capi-md-test-main |
adilGhaffarDev
force-pushed
the
fix-capi-md-test/adil
branch
from
9dabd80 to
b4bd0cd
Compare
|
/test metal3-centos-e2e-capi-md-test-main |
|
/test metal3-ubuntu-e2e-capi-md-test-main |
1 similar comment
|
/test metal3-ubuntu-e2e-capi-md-test-main |
|
cc |
Signed-off-by: Muhammad Adil Ghaffar <muhammad.adil.ghaffar@est.tech>
adilGhaffarDev
force-pushed
the
fix-capi-md-test/adil
branch
from
b4bd0cd to
1a4ed60
Compare
|
/test metal3-centos-e2e-capi-md-test-main |
There was a problem hiding this comment.
Pull request overview
This PR enables support for the CAPI machine taint propagation feature in Metal3's end-to-end tests. CAPI has introduced a taint propagation feature that allows taints to be defined on MachineDeployment specs and propagated to the underlying nodes, and this PR updates the Metal3 e2e test infrastructure to test this capability.
Key changes:
- Updates the MachineDeployment rollout test to use specialized "-md-taints" flavored cluster templates
- Adds new cluster template configurations for both Ubuntu and CentOS that include taint definitions with different propagation modes (OnInitialization and Always)
- Enables the
EXP_MACHINE_TAINT_PROPAGATIONfeature flag in both the e2e configuration and CI script
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/md_rollout_test.go | Updates Flavor to use osType + "-md-taints" template for testing taint propagation |
| test/e2e/data/infrastructure-metal3/main/cluster-template-ubuntu-md-taints/md-taints.yaml | Adds MachineDeployment patch with taint specifications for Ubuntu |
| test/e2e/data/infrastructure-metal3/main/cluster-template-ubuntu-md-taints/kustomization.yaml | Adds kustomization configuration for Ubuntu md-taints template |
| test/e2e/data/infrastructure-metal3/main/cluster-template-centos-md-taints/md-taints.yaml | Adds MachineDeployment patch with taint specifications for CentOS |
| test/e2e/data/infrastructure-metal3/main/cluster-template-centos-md-taints/kustomization.yaml | Adds kustomization configuration for CentOS md-taints template |
| test/e2e/config/e2e_conf.yaml | Switches to CAPI v1.12.0-rc.0 release for testing, adds md-taints templates to provider files, and enables EXP_MACHINE_TAINT_PROPAGATION variable |
| scripts/ci-e2e.sh | Updates CAPI release version, ensures CAPI config directory exists early, appends taint propagation feature flag to clusterctl.yaml, and exports the feature flag for e2e tests |
| Makefile | Adds build commands for the new Ubuntu and CentOS md-taints cluster templates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tuminoid
left a comment
tuminoid
left a comment
There was a problem hiding this comment.
/retitle 🌱 Fix capi-md-e2e test to support taint propagation feature
/approve
metal3-io-bot
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/lgtm |
What this PR does / why we need it:
CAPI added taint propagation feature and updated their e2e test to test it.
We are running same capi test on our side so we also have to update our yamls.
This pr is enabling EXP_MACHINE_TAINT_PROPAGATION and updating md yaml so it can be tested.
Fixes #
Checklist: