Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Rewrite fetch_manifest.sh into golang #2109

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 Rewrite fetch_manifest.sh into golang #2109

wants to merge 1 commit into from

Conversation

peppi-lotta
Copy link
Member

@peppi-lotta peppi-lotta commented Nov 26, 2024 •
edited
Loading

What this PR does / why we need it: Rewrite fetch_manifest.sh into golang.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tuminoid for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@peppi-lotta peppi-lotta marked this pull request as draft November 26, 2024 08:22
@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2024
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/rewrite-fetch-manifest branch from 2f02d44 to 241eae8 Compare November 26, 2024 09:42
@peppi-lotta peppi-lotta marked this pull request as ready for review December 9, 2024 08:50
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2024
lentzi90
lentzi90 reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already an improvement over calling the script from the code. However, it would be even better if we can reuse the function that CAPI already did and get rid of exec.Command at the same time.
See this: https://github.com/kubernetes-sigs/cluster-api/blob/90311aeabd7a1d8f6f47e14259b4c3d34d2b1b07/test/framework/alltypes_helpers.go#L120
Do you think it would be feasible to do?

@lentzi90
Copy link
Member

This PR does something similar in BMO and could be helpful: metal3-io/baremetal-operator#1939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@kashifest kashifest Awaiting requested review from kashifest

@tuminoid tuminoid Awaiting requested review from tuminoid

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peppi-lotta @metal3-io-bot @lentzi90