Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Issue template for preparing new minor release #1748

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 Issue template for preparing new minor release #1748

wants to merge 1 commit into from

Conversation

adilGhaffarDev
Copy link
Member

What this PR does / why we need it:
This PR is adding an issue template for preparing a new minor release. It will make it easier to create tracking issue.

@Sunnatillo
Copy link
Member

That is the great addition. Thanks @adilGhaffarDev

@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2024
tuminoid
tuminoid reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

.github/ISSUE_TEMPLATE/prepare_minor_release.md Outdated

* [ ] Add/edit JJBs to acommodate new build jobs and PR jobs for new release branches. [Prior art](https://gerrit.nordix.org/c/infra/cicd/+/20875)
* [ ] Add Prow jobs for new release branches in Project-infra repo [Prior art](https://github.com/metal3-io/project-infra/pull/697)
* [ ] Prepare dev-env to acommodate release-1.7 related changes and configurations [Prior art](https://github.com/metal3-io/metal3-dev-env/pull/1381)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not put past release versions in the template.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed versions, can you check again

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2024
@adilGhaffarDev adilGhaffarDev force-pushed the add-prepare-minor-temp/adil branch from d8e415b to b455689 Compare June 20, 2024 11:24
@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 20, 2024
tuminoid
tuminoid reviewed Jun 25, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NItting, but also questioning should this be somewhere else than CAPM3?

.github/ISSUE_TEMPLATE/prepare_minor_release.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/prepare_minor_release.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/prepare_minor_release.md Outdated
* [ ] Update Metal3 book. [Prior art](https://github.com/metal3-io/metal3-docs/pull/413)
* [ ] Release Ironic, also check new image is created in quay. [Prior art](https://github.com/metal3-io/ironic-image/tags)
* [ ] Pin Ironic in BMO and release BMO, also check new image is created in quay. [Prior art](https://github.com/metal3-io/baremetal-operator/pull/1679)
* [ ] Release IPAM (Branch out, add branch protection and required tests, also check new image is created in quay).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were documenting IPAM/BMO/Ironic releasing in CAPM3 repo, shouldn't we have this tracking issue in more generic repo, like docs or dev-env or community? Most of these steps do not related to CAPM3 after all.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what is the best place for this. If docs seems like a better place I can add it there. I added it here because the CAPM3 minor release is most of the time dependent on these releases.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CAPM template should be about things done in CAPM3, similar to releasing.md is repo specific. Then in metal3-docs there is one that covers the common/extra steps. IMO these issue templates should be the same.

.github/ISSUE_TEMPLATE/prepare_minor_release.md Outdated Show resolved Hide resolved
@Rozzii Rozzii added this to the 1.8.0 milestone Jun 28, 2024
@Sunnatillo
Copy link
Member

@adilGhaffarDev Let's make this template get merged. This would be great to make release process smoother.

@adilGhaffarDev adilGhaffarDev force-pushed the add-prepare-minor-temp/adil branch from b455689 to c8a853a Compare September 5, 2024 09:34
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 5, 2024
@adilGhaffarDev
Copy link
Member Author

@adilGhaffarDev Let's make this template get merged. This would be great to make the release process smoother.

addressed the comments and also rearranged some tasks. Let me know if anything is missed.

@adilGhaffarDev adilGhaffarDev force-pushed the add-prepare-minor-temp/adil branch from c8a853a to 1193fd4 Compare September 10, 2024 11:34
smoshiur1237
smoshiur1237 reviewed Oct 24, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good after @tuminoid review.. Do we remove the hold? Feel free to remove it.
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
mquhuy
mquhuy reviewed Oct 24, 2024
View reviewed changes
Copy link
Member

@mquhuy mquhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

.github/ISSUE_TEMPLATE/prepare_minor_release.md
* [ ] Uplift CAPI to latest minor in CAPM3, also check migration guide: [Migration guide for providers](https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations). [Prior art CAPM3](https://github.com/metal3-io/cluster-api-provider-metal3/pull/1604).
IMPORTANT: Always read migration guide and make sure to do the changes accordingly in CAPM3 and IPAM.
* [x] Uplift k8s to 1.31 in CAPM3 and metal3-dev-env repo. [Prior art metal3-dev-env](https://github.com/metal3-io/metal3-dev-env/pull/1389), [Prior art CAPM3](https://github.com/metal3-io/cluster-api-provider-metal3/pull/1622)
* [x] Uplift k8s to 1.31 in image building pipeline. [Prior art jjb](https://gerrit.nordix.org/c/infra/cicd/+/22205) [Prior art pipeline](https://github.com/metal3-io/project-infra/pull/836)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 2 uplifts still refer to specific k8s versions, also remove the ticks.

@tuminoid
Copy link
Member

This is marked for 1.9, but it is just template for creating a release. We'll have new automation from IPAM coming in soon, so I think we should move it to 1.10. @adilGhaffarDev is that ok?

@adilGhaffarDev
Copy link
Member Author

This is marked for 1.9, but it is just template for creating a release. We'll have new automation from IPAM coming in soon, so I think we should move it to 1.10. @adilGhaffarDev is that ok?

yes we can move it to 1.10

@tuminoid tuminoid modified the milestones: CAPM3 - v1.9, CAPM3 - v1.10 Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@mquhuy mquhuy mquhuy left review comments

@tuminoid tuminoid tuminoid left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Metal3 - Roadmap
Status: CAPM3 WIP
Milestone
CAPM3 - v1.10
Development

Successfully merging this pull request may close these issues.
8 participants
@adilGhaffarDev @Sunnatillo @kashifest @metal3-io-bot @tuminoid @mquhuy @smoshiur1237 @Rozzii