Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 simplify go version handling in verify-release.sh #2058

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

tuminoid
Copy link
Member

Make use of 'make go-version' rather than parse it from Dockerfile. Cherry-picked from IPAM.

Make use of 'make go-version' rather than parse it from Dockerfile.
Cherry-picked from IPAM.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@tuminoid
Copy link
Member Author

/cc @lentzi90 @kashifest

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 18, 2024
@tuminoid
Copy link
Member Author

/cherry-pick release-0.8

0.6 will be EOS soon, skipping cherry-pick there.

@metal3-io-bot
Copy link
Contributor

@tuminoid: once the present PR merges, I will cherry-pick it on top of release-0.8 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.8

0.6 will be EOS soon, skipping cherry-pick there.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member Author

/retest

Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2024
@tuminoid
Copy link
Member Author

/retest

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
@metal3-io-bot metal3-io-bot merged commit 2a445d5 into metal3-io:main Nov 18, 2024
17 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/simplify-verify-release branch November 18, 2024 13:11
@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #2059

In response to this:

/cherry-pick release-0.8

0.6 will be EOS soon, skipping cherry-pick there.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants