use uuidgen to generate random username/password

Using /dev/urandom has entropy issue. It can run out especially in CI, leaving jobs stuck. We have used uuidgen in BMO e2e for long time now and it works great. These usernames/passwords just need to be anything random to make sure nothing is hardcoded, so uuidgen works great for that anyways. Signed-off-by: Tuomo Tanskanen <[email protected]>
metal3-io · Nov 20, 2024 · d3c83b8 · d3c83b8
1 parent 77ad450
commit d3c83b8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/tools/deploy.sh b/tools/deploy.sh
@@ -127,15 +127,15 @@ mkdir -p "${IRONIC_AUTH_DIR}"
 if [[ "${DEPLOY_BASIC_AUTH}" == "true" ]]; then
     if [ -z "${IRONIC_USERNAME:-}" ]; then
         if [ ! -f "${IRONIC_AUTH_DIR}ironic-username" ]; then
-            IRONIC_USERNAME="$(tr -dc 'a-zA-Z0-9' < /dev/urandom | fold -w 12 | head -n 1)"
+            IRONIC_USERNAME="$(uuidgen)"
             echo "$IRONIC_USERNAME" > "${IRONIC_AUTH_DIR}ironic-username"
         else
             IRONIC_USERNAME="$(cat "${IRONIC_AUTH_DIR}ironic-username")"
         fi
     fi
     if [ -z "${IRONIC_PASSWORD:-}" ]; then
         if [ ! -f "${IRONIC_AUTH_DIR}ironic-password" ]; then
-            IRONIC_PASSWORD="$(tr -dc 'a-zA-Z0-9' < /dev/urandom | fold -w 12 | head -n 1)"
+            IRONIC_PASSWORD="$(uuidgen)"
             echo "$IRONIC_PASSWORD" > "${IRONIC_AUTH_DIR}ironic-password"
         else
             IRONIC_PASSWORD="$(cat "${IRONIC_AUTH_DIR}ironic-password")"