Skip to content

Commit

Permalink
Merge pull request #2084 from dtantsur/no-colon
Browse files Browse the repository at this point in the history
🌱 Do not add colons to structured logging
  • Loading branch information
metal3-io-bot authored Dec 2, 2024
2 parents b52485e + 1a4ac65 commit a657739
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion controllers/metal3.io/baremetalhost_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ func (r *BareMetalHostReconciler) Reconcile(ctx context.Context, request ctrl.Re
msg = err.Error()
}
provisionerNotReady.Inc()
reqLogger.Info("provisioner is not ready", "Error:", msg, "RequeueAfter:", provisionerNotReadyRetryDelay)
reqLogger.Info("provisioner is not ready", "Error", msg, "RequeueAfter", provisionerNotReadyRetryDelay)
return ctrl.Result{Requeue: true, RequeueAfter: provisionerNotReadyRetryDelay}, nil
}

Expand Down
4 changes: 2 additions & 2 deletions controllers/metal3.io/bmceventsubscription_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ func (r *BMCEventSubscriptionReconciler) Reconcile(ctx context.Context, request
} else {
msg = err.Error()
}
reqLogger.Info("provisioner is not ready", "Error:", msg, "RequeueAfter:", provisionerNotReadyRetryDelay)
reqLogger.Info("provisioner is not ready", "Error", msg, "RequeueAfter", provisionerNotReadyRetryDelay)
return ctrl.Result{RequeueAfter: provisionerNotReadyRetryDelay}, nil
}

Expand Down Expand Up @@ -229,7 +229,7 @@ func (r *BMCEventSubscriptionReconciler) getProvisioner(ctx context.Context, req
} else {
msg = err.Error()
}
reqLogger.Info("provisioner is not ready", "Error:", msg, "RequeueAfter:", provisionerNotReadyRetryDelay)
reqLogger.Info("provisioner is not ready", "Error", msg, "RequeueAfter", provisionerNotReadyRetryDelay)
return prov, ready, nil
}

Expand Down

0 comments on commit a657739

Please sign in to comment.