Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network isolation validation #391

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Conversation

robertvolkmann
Copy link
Contributor

Validate network isolation configuration in a single location rather than performing validation in multiple places

@robertvolkmann robertvolkmann requested a review from a team as a code owner March 14, 2024 10:47
@Gerrit91 Gerrit91 requested a review from vknabel March 14, 2024 13:12
@robertvolkmann
Copy link
Contributor Author

robertvolkmann commented Mar 14, 2024

@vknabel Do want to support empty RegistryMirrors or not?

if p.NetworkIsolation == nil || len(p.NetworkIsolation.RegistryMirrors) == 0 {

@vknabel
Copy link
Contributor

vknabel commented Mar 25, 2024

@robertvolkmann if the network access type is not baseline, the NetworkIsolation and its RegistryMirrors must be set and contain at least one mirror.

@majst01
Copy link
Contributor

majst01 commented Jun 27, 2024

rebase and run in test

@vknabel vknabel force-pushed the network-isolation-validation branch from a58cbd2 to c049cd3 Compare June 27, 2024 06:54
@vknabel vknabel self-assigned this Jun 27, 2024
@vknabel vknabel self-requested a review June 27, 2024 06:57
@vknabel
Copy link
Contributor

vknabel commented Jul 3, 2024

Worked fine in test

@vknabel vknabel merged commit 5be3df9 into master Aug 2, 2024
2 checks passed
@vknabel vknabel deleted the network-isolation-validation branch August 2, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants