Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG-FIX] Make it so parsoid can contact nginx #64

Merged
merged 2 commits into from
Jul 17, 2019
Merged

Conversation

icyflame
Copy link
Member

@icyflame icyflame commented Jul 17, 2019

Background

This bug was introduced in #49. Parsoid needs to contact nginx, but the networks were not set up correctly, which caused the visual editor to stop working.

Cause

I tested the new setup locally but I was only testing the source edit function. Developers should remember to use both Source Edit and Visual Editor when making changes to the wiki because VE is a popular choice among many users (especially people who are new to the wiki / mediawiki markup language)

Detection

After deploying the mediawiki update to 1.33, we realized that source edits were working but the Visual Editor was not working. The logs of the parsoid container had the reason for this error:

{"name":"parsoid","hostname":"a815b3504bee","pid":36,"level":60,"err":{"message":"Config Request failure for \"http://nginx/api.php\": Error: getaddrinfo ENOTFOUND nginx nginx:80","name":"lib/index.js","stack":"lib/index.js: Config Request failure for \"http://nginx/api.php\": Error: getaddrinfo ENOTFOUND nginx nginx:80\n    at ConfigRequest.ApiRequest._requestCB (/home/parsoid/parsoid/lib/mw/ApiRequest.js:415:15)\n    at self.callback (/home/parsoid/parsoid/node_modules/request/request.js:185:22)\n    at emitOne (events.js:116:13)\n    at Request.emit (events.js:211:7)\n    at Request.onRequestError (/home/parsoid/parsoid/node_modules/request/request.js:877:8)\n    at emitOne (events.js:121:20)\n    at ClientRequest.emit (events.js:211:7)\n    at Socket.socketErrorListener (_http_client.js:387:9)\n    at emitOne (events.js:116:13)\n    at Socket.emit (events.js:211:7)\n    at emitErrorNT (internal/streams/destroy.js:64:8)\n    at _combinedTickCallback (internal/process/next_tick.js:138:11)\n    at process._tickCallback (internal/process/next_tick.js:180:9)","levelPath":"fatal/request"},"msg":"Config Request failure for \"http://nginx/api.php\": Error: getaddrinfo ENOTFOUND nginx nginx:80","time":"2019-07-17T01

Action Items

Mitigation

  • Deploy this fix

docker-compose.yml Outdated Show resolved Hide resolved
@amrav
Copy link
Member

amrav commented Jul 17, 2019

Also should upgrade parsoid to 0.10.0 (should be a one-liner), but not necessary in this PR

@icyflame icyflame merged commit 9e1a161 into master Jul 17, 2019
@thealphadollar thealphadollar deleted the fix-visual-editor branch July 17, 2019 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants