Integration tests! #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to specify a base (docker-compose.yml), common configuration for devel (docker-compose.override.yml), and production specific configuration (docker-compose.prod.yml). When developing, you can continue to use `docker-compose ...` commands without passing any special options. This is nice because: - We don't need to spin up some services in devel (like backups) - It will make it possible to reuse the common configuration for integration tests, which will specify their own overrides to avoid clashing with any devel volumes.
amrav
force-pushed
the
amrav/integration-tests
branch
6 times, most recently
from
1bd18fd
to
6899615
Compare
- Define integration test config override, which basically renames all the volumes to avoid clashing with any existing volumes. - Add test setup, which starts all the services and installs mediawiki using the CLI installer. - Add an example test, which loads the Main Page. More to come. - Add integration tests to the Travis CI config.
amrav
force-pushed
the
amrav/integration-tests
branch
from
6899615
to
f23b2ce
Compare
hargup
requested changes
Jun 18, 2017
There was a problem hiding this comment.
Can you add a few lines of instructions in the README about how to use the different docker files for the production and debugging purposes. Possibly including links to relevant documentation.
Also, at the moment you are testing if mediawiki is firing up properly, which is great! After the PR is merged please add issues that other more comprehensive tests needs to be added.
- Add info about docker-compose multiple config files - Add more instructions for running locally This is not yet in a state where it's easy to run locally. Future patches will reduce the complexity, but this is the best we can do for now.
|
Created #14 to track adding more integration tests. Hopefully the readme is a bit more informative now. |
hargup
approved these changes
Jun 19, 2017
amrav
pushed a commit
that referenced
this pull request
Sep 12, 2017
Config to set Slack avatar for bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings us closer to being able to deploy master automatically with confidence.