connection.sync for enabling/disabling synchronous connections (good for disconnect on unload) #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for a widely believed feature of Strophe that doesn't seem to actually be supported. Setting connection.sync = true is believed to force synchronous connections according to many blog and forum posts. The source doesn't seem to support this at all. This little patch makes that vaporware feature a reality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for a widely believed feature of Strophe that doesn't seem to actually be supported.
Setting connection.sync = true is believed to force synchronous connections according
to many blog and forum posts. The source doesn't seem to support this at all. This little
patch makes that vaporware feature a reality.
e.g. disconnect in window.unload examples