Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URLEncode to be backwards compatible #507

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

dr0i
Copy link
Member

@dr0i dr0i commented Nov 14, 2023

Following metafacture/metafacture-fix#273 (comment).

Complements #490.

Sets default safe characters ".", "-", "*", and "_", following URLEncode.

Prerequisite for metafacture/metafacture-fix#273 and #502.

Copy link
Member

@blackwinter blackwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor issue. Otherwise 👍

@blackwinter blackwinter assigned dr0i and unassigned blackwinter Nov 15, 2023
@dr0i dr0i merged commit dd3ca08 into master Nov 16, 2023
@dr0i dr0i deleted the metafacture-fix-273-fixUrlEncode branch November 16, 2023 15:00
@dr0i dr0i mentioned this pull request Nov 16, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants