Don't rewrite a search prefix when attempting a suggestion

.github/workflows/test.yml

@@ -68,23 +68,49 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Build test image
-        id: docker-build-test
+        id: docker-build-playwright
         uses: docker/build-push-action@v6
         with:
-          target: server
+          target: playwright
           push: false
           load: true
-      - name: Run Perl tests
+      - name: Start playwright server
+        id: start-container
         run: >
-          docker run -d -i -p 8000:80
-          ${{ steps.docker-build-test.outputs.imageid }}
+          CONTAINER_ID=$(docker run -d -i -p 8000:80
+          -v $(pwd):/app
+          ${{ steps.docker-build-playwright.outputs.imageid }})
+          && echo "container_id=$CONTAINER_ID" >> $GITHUB_OUTPUT
+          || (echo "Failed to start container" && exit 1)
       - uses: actions/setup-node@v4
         with:
           node-version: 22
       - name: Install Playwright Browsers
         run: ./bin/install-playwright
+      - name: Install Codecovbash
+        uses: perl-actions/install-with-cpm@v1
+        with:
+          install: |
+            Devel::Cover
+            Devel::Cover::Report::Codecovbash
+          sudo: true
+      - name: Check docker status
+        id: playwright-tests
+        run: |
+          npx playwright test || {
+            echo "Playwright tests failed"
+            docker logs ${{ steps.start-container.outputs.container_id }}
+            exit 1
+          }
       - name: Run Playwright tests
         run: npx playwright test
+      - name: Generate Codecov report
+        run: cover -report codecovbash
+      - uses: codecov/codecov-action@v5
+        with:
+          fail_ci_if_error: true
+          file: ./cover_db/codecov.json
+          token: ${{ secrets.CODECOV_TOKEN }}
   test:
     runs-on: ubuntu-24.04
     name: Dockerless

Dockerfile

@@ -123,3 +123,18 @@ CMD [ "prove", "-l", "-r", "-j", "2", "t" ]
 FROM server AS production
 
 USER metacpan
+
+################### Playwright Server
+FROM server AS playwright
+USER root
+
+RUN echo "Starting Playwright stage setup"
+RUN    --mount=type=cache,target=/root/.perl-cpm,sharing=private \
+<<EOT
+    cpm install --show-build-log-on-failure Devel::Cover \
+EOT
+
+ENV HARNESS_ACTIVE=1
+ENV PERL5OPT='-MDevel::Cover=+ignore,^local/|^templates/|^t/|yaml$'
+
+USER metacpan

e2e/home.spec.ts

@@ -1,6 +1,48 @@
-import { test, expect } from '@playwright/test';
+import { test, expect } from "@playwright/test";
 
-test('home page', async ({ page }) => {
-  await page.goto('/');
-  await expect(page).toHaveTitle(/Search the CPAN - metacpan.org/, { timeout: 10 });
+test("home page", async ({ page }) => {
+    await page.goto("/");
+    await expect(page).toHaveTitle(/Search the CPAN - metacpan.org/, {
+        timeout: 10,
+    });
+});
+
+test("suggest is correct", async ({ page }) => {
+    await page.goto("/");
+    const searchInput = page.getByPlaceholder("Search the CPAN");
+    await expect(searchInput).toBeVisible();
+    searchInput.fill("HTML:Restrict");
+    await searchInput.press("Enter");
+
+    await expect(page.getByRole('alert')).toContainText('Did you mean: HTML::Restrict');
+});
+
+test("suggest accounts for prefix and makes suggestion", async ({ page }) => {
+    await page.goto("/");
+    const searchInput = page.getByPlaceholder("Search the CPAN");
+    await expect(searchInput).toBeVisible();
+    searchInput.fill("distribution:HTML:Restrict");
+    await searchInput.press("Enter");
+
+    await expect(page.getByRole('alert')).toContainText('Did you mean: distribution:HTML::Restrict');
+});
+
+test("suggest accounts for prefix but cannot make suggestion", async ({ page }) => {
+    await page.goto("/");
+    const searchInput = page.getByPlaceholder("Search the CPAN");
+    await expect(searchInput).toBeVisible();
+    searchInput.fill("distribution:HTMLRestrict");
+    await searchInput.press("Enter");
+
+    await expect(page.getByRole('alert')).toBeHidden();
+});
+
+test("suggest ignores misspelled prefix and makes suggestion", async ({ page }) => {
+    await page.goto("/");
+    const searchInput = page.getByPlaceholder("Search the CPAN");
+    await expect(searchInput).toBeVisible();
+    searchInput.fill("disstribution:HTML:Restrict");
+    await searchInput.press("Enter");
+
+    await expect(page.getByRole('alert')).toContainText('Did you mean: disstribution::HTML::Restrict');
 });

lib/MetaCPAN/Web/Controller/Search.pm

@@ -84,10 +84,14 @@
 
         if ( !$results->{total} && !$authors->{total} ) {
             my $suggest = $query;
+            my $prefix  = q{};
+            if ( $suggest =~ s{^(author|distribution|module|version):}{} ) {
+                $prefix = $1 . ':';
+            }
             $suggest =~ s/\s*:+\s*/::/g;
-            if ( $suggest ne $query ) {
+            if ( $prefix . $suggest ne $query ) {
                 $c->stash( {
-                    suggest => $suggest,
+                    suggest => $prefix . $suggest,
                 } );
             }
             $c->stash( {

root/home.tx

@@ -33,7 +33,7 @@
       <img src="/static/images/metacpan-logo.svg" alt="MetaCPAN" />
     </div>
     <h4>A search engine for <a href="https://www.cpan.org">CPAN</a></h4>
-    <form action="/search" class="search-form form-horizontal">
+    <form action="/search" class="search-form form-horizontal" role="search">
       <input type="hidden" name="size" id="metacpan_search-size" value="20">
       <div class="form-group">
           <div class="search-group">

root/no_result.tx

@@ -5,8 +5,8 @@
 <div class="no-results">
     <h3 class="search-results-header">No search results for [% $search_query %]</h3>
     %%  if $suggest {
-            <div class="alert alert-danger">
-                Did you mean :
+            <div class="alert alert-danger" role="alert">
+                Did you mean:
                 <a href="/search?q=[% $suggest | uri %]">[% $suggest %]</a>
             </div>
     %%  }