Skip to content

Commit

Permalink
use envs instead of matrix in the ci for the versions
Browse files Browse the repository at this point in the history
  • Loading branch information
mostafa committed Aug 15, 2024
1 parent f5798d6 commit 23b0736
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
12 changes: 7 additions & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,18 @@ on:
branches:
- main

env:
pythonVersion: 3.12
nodeVersion: 20

jobs:
test:
name: Test on ${{ matrix.os }} with ${{ matrix.env }}
name: Test ${{ matrix.env }} on ${{ matrix.os }}
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
env: [cli, faas]
nodeVersion: [14] # For environments requiring Node.js
pythonVersion: [3.12] # For environments requiring Python

steps:
- name: Checkout code
Expand All @@ -25,7 +27,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.pythonVersion }}
python-version: ${{ env.pythonVersion }}

- name: Install MetaCall (CLI only - Ubuntu)
if: matrix.env == 'cli' && matrix.os == 'ubuntu-latest'
Expand All @@ -45,7 +47,7 @@ jobs:
if: matrix.env == 'faas'
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.nodeVersion }}
node-version: ${{ env.nodeVersion }}

- name: Install MetaCall Deploy and FaaS (FaaS only)
if: matrix.env == 'faas'
Expand Down
2 changes: 0 additions & 2 deletions testing.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import argparse

import config

from testing.logger import Logger
from testing.repo_manager import RepoManager
from testing.deploy_manager import DeployManager
Expand Down

0 comments on commit 23b0736

Please sign in to comment.