Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file upload bug (fixes #56) #57

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

HeeManSu
Copy link
Contributor

@HeeManSu HeeManSu commented Jul 19, 2024

This PR addresses the issue with the file upload process. See the related issue here.

@viferga
Copy link
Member

viferga commented Jul 22, 2024

This is half of the method, but you really got it. Now there is the lacking part for defining the promise in the unzip process and resolve it once the unzip is done.

I can help you in that part if you need assistance. The upload and unzip part is a bit messy.

@viferga viferga marked this pull request as draft July 22, 2024 18:04
@HeeManSu HeeManSu marked this pull request as ready for review November 5, 2024 02:30
@viferga viferga merged commit 8bce92f into metacall:master Nov 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants