[WIP] fix: pr-33 warnings and scripts loading error #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creatoon
suggested changes
Mar 13, 2024
|
|
||
| res.status(201).send({ id }); | ||
| res.status(201).send({ appName }); |
There was a problem hiding this comment.
This is wrong, the response must contain id
It should be like
id:appName
|
@aakritiawasthi does this patch include the versioning? It should not be solved by versioning as we talked. It must check if it is already deployed and do not deploy it again. And on startup, load all the stored deployments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #35
This pr is in under progress, There are some changes that needs to be done in Deploy CLI too after this change
This PR includes: