Don't ignore disallowed children HTML errors #3482
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
react-table (at least the versions before v8, which is a complete rewrite we don't want to deal with yet) add role attributes for ARIA purposes even when they are completely useless and actually fail HTML validation. See TanStack/table#2862 This implements the suggestion in the last comment on that PR, actively dropping any role that react-table might add. In our usage, these should always be useless AFAICT since our tables are generally actual tables.
When we changed this file several years ago, we forgot to do so that loading the form with jQuery will still set the cookie to keep the filter open next time. Before commit 49ab946 we always started from scratch after loading the form, so the cookie got set that way.
This was wrongly converted from the TT paginator, which just closes the separator li before opening the next. I'm not sure if this is even valid (probably not really?) but it doesn't seem to have any purpose in any case and it triggers validation tests about the two closing /li in a row.
This is needed for form rel attributes to be accepted as valid.
SidebarProperties is a dl, and IsrcList / IswcList return a hydrated div containing a separate dl. You cannot have the div inside a dl, but that's not even the main problem, since you also cannot have nested dls... This just needs to be alongside the SidebarProperties dl instead of inside of it. Nothing seems to change in the display on Chrome at least.
reosarevok
force-pushed
the
punish-bad-children
branch
from
37796c9 to
a32be37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now a draft to see how much if any test screaming this still causes.