Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix depreciation WARN log message #92

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

RokLenarcic
Copy link

The Audience class just redirects to getURI and logs WARN message:

    @Nullable
    default String getAudienceURI() {
        DeprecationSupport.warn(ObjectType.METHOD, "getAudienceURI", Audience.class.toString(), "getURI");
        return this.getURI();
    }

@RokLenarcic RokLenarcic requested a review from camsaul as a code owner February 19, 2025 08:08
@camsaul camsaul requested a review from a team February 21, 2025 00:34
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.03%. Comparing base (399a475) to head (80e2c9b).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   75.03%   75.03%           
=======================================
  Files          10       10           
  Lines         693      693           
  Branches      101      101           
=======================================
  Hits          520      520           
  Misses         72       72           
  Partials      101      101           
Flag Coverage Δ
cloverage 75.03% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edpaget edpaget merged commit 763ea2a into metabase:master Feb 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants