Add unit tests for ncclxParseCommConfig#985
Open
pavanbalaji wants to merge 2 commits intometa-pytorch:mainfrom
Open
Add unit tests for ncclxParseCommConfig#985pavanbalaji wants to merge 2 commits intometa-pytorch:mainfrom
pavanbalaji wants to merge 2 commits intometa-pytorch:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
Contributor
|
@pavanbalaji has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95714600. |
pavanbalaji
added a commit
to pavanbalaji/torchcomms-1
that referenced
this pull request
Mar 9, 2026
Summary: Pull Request resolved: meta-pytorch#985 Add unit tests exercising ncclxParseCommConfig, covering flat ncclConfig_t fields, hints-based configuration, default values, idempotency, and conflict detection between flat fields and hints. Applied identically to v2_27, v2_28, and v2_29. Differential Revision: D95714600
pavanbalaji
force-pushed
the
export-D95714600
branch
2 times, most recently
from
792f4ea to
8365cc9
Compare
pavanbalaji
added a commit
to pavanbalaji/torchcomms-1
that referenced
this pull request
Mar 9, 2026
Summary: Pull Request resolved: meta-pytorch#985 Add unit tests exercising ncclxParseCommConfig, covering flat ncclConfig_t fields, hints-based configuration, default values, idempotency, and conflict detection between flat fields and hints. Applied identically to v2_27, v2_28, and v2_29. Differential Revision: D95714600
pavanbalaji
force-pushed
the
export-D95714600
branch
from
8365cc9 to
ba1ff47
Compare
Summary: Remove ncclxParseCommConfig from inside parseCommConfig (a low-level function) and call it from the three comm-init entry points instead: ncclCommInitRankConfig (already there from prior commit), ncclCommInitChildComm, and ncclCommGrow (v2_29 only). This ensures ncclx::Config is created early at each public entry point rather than deep inside a shared helper, making the initialization flow clearer and more explicit. Differential Revision: D95714601
pavanbalaji
force-pushed
the
export-D95714600
branch
from
ba1ff47 to
b9111bc
Compare
pavanbalaji
added a commit
to pavanbalaji/torchcomms-1
that referenced
this pull request
Mar 11, 2026
Summary: Add unit tests exercising ncclxParseCommConfig, covering flat ncclConfig_t fields, hints-based configuration, default values, idempotency, and conflict detection between flat fields and hints. Applied identically to v2_27, v2_28, and v2_29. Reviewed By: minsii Differential Revision: D95714600
Summary: Pull Request resolved: meta-pytorch#985 Add unit tests exercising ncclxParseCommConfig, covering flat ncclConfig_t fields, hints-based configuration, default values, idempotency, and conflict detection between flat fields and hints. Applied identically to v2_27, v2_28, and v2_29. Reviewed By: minsii Differential Revision: D95714600
pavanbalaji
force-pushed
the
export-D95714600
branch
from
b9111bc to
b7be159
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add unit tests exercising ncclxParseCommConfig, covering
flat ncclConfig_t fields, hints-based configuration, default
values, idempotency, and conflict detection between flat
fields and hints.
Applied identically to v2_27, v2_28, and v2_29.
Differential Revision: D95714600