Remove incorrect ncclx:: prefix from RMA APIs#982
Open
pavanbalaji wants to merge 4 commits intometa-pytorch:mainfrom
Open
Remove incorrect ncclx:: prefix from RMA APIs#982pavanbalaji wants to merge 4 commits intometa-pytorch:mainfrom
pavanbalaji wants to merge 4 commits intometa-pytorch:mainfrom
Conversation
Summary: Update v2_27 tests for the CtranMapperRegCache -> ctran::RegCache rename: - CommRegisterTest.cc: update include path and class name - CtranExDistCommUT.cc: add include and update class name - CtranExDistCommFailureUT.cc: disambiguate testing:: namespace All three files also fix ambiguous 'testing' namespace references caused by ctran::testing conflicting with ::testing from gtest. Differential Revision: D95714490
Summary: Rename NCCL_DEBUG_FILE_DEFAULT to NCCL_DEBUG_FILE_DEFAULTCVARVALUE to match the current CVAR code generation convention. Differential Revision: D95714491
Summary: Make HelloWorld.cu self-contained by inlining MPI/NCCL setup logic and including tests_common.cuh instead of TestsDistUtils.h, which pulls in NCCL internal headers incompatible with CUDA compilation. Differential Revision: D95714488
Summary: Remove ncclx:: namespace prefix from ncclPutSignal, ncclWaitSignal, ncclPut, and ncclGet calls. These are C API functions declared at global scope in nccl.h, not in the ncclx namespace. Differential Revision: D95714489
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Remove ncclx:: namespace prefix from ncclPutSignal,
ncclWaitSignal, ncclPut, and ncclGet calls. These are
C API functions declared at global scope in nccl.h, not
in the ncclx namespace.
Differential Revision: D95714489