fix: update pyproject.toml path in base Dockerfile#327
Open
targeted-DK wants to merge 1 commit intometa-pytorch:mainfrom
Open
fix: update pyproject.toml path in base Dockerfile#327targeted-DK wants to merge 1 commit intometa-pytorch:mainfrom
targeted-DK wants to merge 1 commit intometa-pytorch:mainfrom
Conversation
Contributor
Greptile OverviewGreptile SummaryFixed broken
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Docker as Docker Build
participant Repo as Repository Root
participant Dockerfile as Dockerfile
Dev->>Docker: docker build -f src/openenv/core/containers/images/Dockerfile .
Docker->>Dockerfile: Read build instructions
Dockerfile->>Repo: COPY pyproject.toml uv.lock* ./
Repo-->>Dockerfile: ✓ Files copied (fixed path)
Dockerfile->>Docker: RUN uv pip install --system -r pyproject.toml
Docker-->>Dev: ✓ Image built successfully
|
Contributor
Additional Comments (1)
Prompt To Fix With AIThis is a comment left during a code review.
Path: src/openenv/core/containers/images/Dockerfile
Line: 14:14
Comment:
outdated path in comment - should be `-f src/openenv/core/containers/images/Dockerfile`
```suggestion
# Build from repo root: docker build -t openenv-base:latest -f src/openenv/core/containers/images/Dockerfile .
```
How can I resolve this? If you propose a fix, please make it concise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Alignment Checklist
Before submitting, verify:
.claude/docs/PRINCIPLES.mdand this PR aligns with our principles.claude/docs/INVARIANTS.mdand no invariants are violated/pre-submit-pr(orbash .claude/hooks/lint.shand tests) and addressed all issuesRFC Status
Test Plan
I verified the path fix by running a full build of the base image for finrl_env. Since the previous COPY path was broken, the build used to fail at step 3. With this fix, it completes successfully.
Command: docker build -t envtorch-base:latest -f ./src/openenv/core/containers/images/Dockerfile .
Claude Code Review
NA