Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support llama3.1 8B instruct in post training #698

Merged
merged 3 commits into from
Jan 4, 2025
Merged

support llama3.1 8B instruct in post training #698

merged 3 commits into from
Jan 4, 2025

Conversation

SLR722
Copy link
Contributor

@SLR722 SLR722 commented Dec 31, 2024 •
edited
Loading

What does this PR do?

  • Change to support llama3.1 8B instruct model other than llama3 8B model as llama3.1 8B instruct model is a better model to finetune on top of
  • Make the copy files logic in checkpointer safer in case the file be copied doesn't exist in source path

test

issue a post training request from client and verify training works as expect
Screenshot 2025-01-02 at 12 18 45 PM

Screenshot 2025-01-02 at 12 18 52 PM

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 31, 2024
@SLR722 SLR722 marked this pull request as ready for review January 2, 2025 23:23
@SLR722 SLR722 merged commit e86271a into main Jan 4, 2025
2 checks passed
@SLR722 SLR722 deleted the support_3pt1_8b branch January 4, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanxi0830 yanxi0830 yanxi0830 approved these changes

@ashwinb ashwinb Awaiting requested review from ashwinb ashwinb is a code owner

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@raghotham raghotham Awaiting requested review from raghotham raghotham is a code owner

@dineshyv dineshyv Awaiting requested review from dineshyv dineshyv is a code owner

@vladimirivic vladimirivic Awaiting requested review from vladimirivic vladimirivic is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SLR722 @yanxi0830 @facebook-github-bot