Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform for docker #622

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

VladOS95-cyber
Copy link

@VladOS95-cyber VladOS95-cyber commented Dec 13, 2024

What does this PR do?

It is possible to specify platform param in the cmd args llama stack build --template local --image-type docker --platform linux/amd64 --name llama-stack

#253

Test Plan

Please describe:

  • tests you ran to verify your changes with result summaries.
  • provide instructions so it can be reproduced.

Sources

Please link relevant resources if necessary.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Ran pre-commit to handle lint / formatting issues.
  • Read the contributor guideline,
    Pull Request section?
  • Updated relevant documentation.
  • Wrote necessary unit or integration tests.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 13, 2024
@VladOS95-cyber VladOS95-cyber force-pushed the add-target-platform-docker branch from 24f0f91 to 89aadb7 Compare December 16, 2024 17:27
@VladOS95-cyber VladOS95-cyber marked this pull request as ready for review December 16, 2024 17:28
@VladOS95-cyber
Copy link
Author

Hi @ashwinb @yanxi0830 @hardikjshah @dltn @raghotham! This PR is ready for a review. Please, take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants