-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Italian Lipsync #54
base: main
Are you sure you want to change the base?
Italian Lipsync #54
Conversation
Italian Lipsync preprocessor
Great. Thank you for sharing! I tried the class in my test environment, but I couldn't get it to work. It always ended up in an infinite loop. I also tried calling the methods directly, for example, I think the reason for this is that for each letter, the last rule should be the letter itself and the most common viseme. For example, for As this problem occurs almost every time, I encourage you to ensure that in your setup, you are actually using this lip-sync module and not one of the existing modules. Additionally, in the rules, there are now a lot of viseme names such as I don't speak Italian, and I know quite little about Italian phonology, but if you have time to work on these issues, I can help you test the module. Italian is a phonetically orthographic language, and in that regard, it resembles Finnish. |
Now properly termitates the loop.
That looks promising, and I also got the class working in my test environment. Here is a short (unlisted) video clip I recorded: https://youtu.be/fw17X7cmvx8 The lip-sync accuracy is not too bad, but the rules still need some adjustment. This is often the trickiest part. The rules don't have to be perfect, of course, just enough to maintain the illusion. First, you should check that all those right hand side visemes in your rules are indeed valid Oculus visemes, which are: One issue that I noticed in your screenshot is the duration your rule set gives to the viseme The rule logic might seem a bit confusing at first, but you can always refer to the original 1976 US Navy paper. A good way to verify your rule set is to download some open-source Italian phoneme dictionary, convert its phonemes to visemes, and then run each word through your class and compare the results. This would give you a percentage indicating how accurate your rule set is. |
Yesterday I did some live tests and they where acceptable, but yes, some words works better than others. I took a look at the demo you made, the lipsync in that case was almost spot on. I'll keep working on it. |
This reverts commit 09d7c7b.
Italian Lipsync preprocessor :D